AudioBufferSourceNode.buffer setter should throw when the buffer was already set

[Chris Dumez]

AudioBufferSourceNode.buffer setter should throw when the buffer was already set:
- https://www.w3.org/TR/webaudio/#dom-audiobuffersourcenode-buffer

[Chris Dumez]

Created attachment 406599 [details]
Patch

[Darin Adler]

Comment on attachment 406599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406599&action=review

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:55
>      // returns true on success.

This comment seems wrong.

> Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h:101
> +    virtual bool isWebKitAudioBufferSourceNode() const { return false; }

This is a little ugly. I guess it’s how we do dynamic type checks, but I could imagine this being a policy function — "can set buffer twice" or whatever — rather than a type check function.

[Chris Dumez]

Created attachment 406608 [details]
Patch

[EWS]

Committed r265681: <https://trac.webkit.org/changeset/265681>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406608 [details].

[Radar WebKit Bug Importer]

<rdar://problem/67084911>