Bug 215503 - [GTK][WPE] Remove support for NPAPI plugins
Summary: [GTK][WPE] Remove support for NPAPI plugins
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2020-08-14 08:03 PDT by Carlos Garcia Campos
Modified: 2020-08-17 06:27 PDT (History)
18 users (show)

See Also:

Patch (202.09 KB, patch)
2020-08-14 08:41 PDT, Carlos Garcia Campos
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-08-14 08:03:08 PDT
Now that we have branched for 2.30 it's a good moment to finally remove the plugins support.
Comment 1 Carlos Garcia Campos 2020-08-14 08:41:48 PDT
Created attachment 406594 [details]

I hope I caught all tests using plugins, I'll watch the bots once the patch lands. I'll also close all bug reports about plugins.
Comment 2 EWS Watchlist 2020-08-14 08:43:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Darin Adler 2020-08-14 10:42:01 PDT
Comment on attachment 406594 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=406594&action=review

> LayoutTests/platform/glib/TestExpectations:956
> +# Plugins

Here’s a follow-up task that’s helpful for clarity and the future, but is a little extra work because of the platforms that still do have the plug-in support around.

Seems like it’s worthwhile to *move* these tests all into the plugins and http/tests/plugins directories.

Except for the tests that just *happen* to use plug-ins that could be redone to test the same thing without a plug-in. Those we could *copy* into the plugins or http/tests/plugins directory and modify (and possibly rename) the original to not use plug-ins any more.

It could be a little bit of a pain to do those moves, but I think it’s good for the health of the project. And it would also make this skipping only two lines long.

The alternative is to wait until we can delete plug-in support on all platforms, then we can delete instead of moving.
Comment 4 Carlos Garcia Campos 2020-08-17 05:41:16 PDT
Committed r265753: <https://trac.webkit.org/changeset/265753>