VoiceOver not able to invoke play button on some web sites.

[Andres Gonzalez]

VoiceOver not able to invoke play button on some web sites.

[Andres Gonzalez]

Created attachment 406563 [details]
Patch

[Andres Gonzalez]

<rdar://problem/62729643>

[Andres Gonzalez]

For instance, the play buttons in https://threema.ch/en/faq/callsounds.

[EWS]

Committed r265645: <https://trac.webkit.org/changeset/265645>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406563 [details].

[Darin Adler]

Comment on attachment 406563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90
> +        for (auto eventName : touchEventNames) {

This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn.

[Darin Adler]

Comment on attachment 406563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review

>> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90
>> +        for (auto eventName : touchEventNames) {
> 
> This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn.

Because we’re using reference_wrapper that might require adding a * below. But it will make things a tiny bit more efficient.