RESOLVED FIXED 215484
VoiceOver not able to invoke play button on some web sites. 
https://bugs.webkit.org/show_bug.cgi?id=215484
Summary VoiceOver not able to invoke play button on some web sites.
Andres Gonzalez
Reported 2020-08-13 18:22:15 PDT
VoiceOver not able to invoke play button on some web sites.
Attachments
Patch (11.50 KB, patch)
2020-08-13 18:31 PDT, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andres Gonzalez
Comment 1 2020-08-13 18:31:25 PDT
Created attachment 406563 [details] Patch
Andres Gonzalez
Comment 2 2020-08-13 18:33:51 PDT
<rdar://problem/62729643>
Andres Gonzalez
Comment 3 2020-08-13 18:38:41 PDT
For instance, the play buttons in https://threema.ch/en/faq/callsounds.
EWS
Comment 4 2020-08-13 22:33:42 PDT
Committed r265645: <https://trac.webkit.org/changeset/265645> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406563 [details].
Darin Adler
Comment 5 2020-08-14 14:57:38 PDT
Comment on attachment 406563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90 > + for (auto eventName : touchEventNames) { This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn.
Darin Adler
Comment 6 2020-08-14 14:58:34 PDT
Comment on attachment 406563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406563&action=review >> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:90 >> + for (auto eventName : touchEventNames) { > > This should use auto& so we get const AtomString&, rather than auto, which gives us AtomString, otherwise we will have unnecessary reference count churn. Because we’re using reference_wrapper that might require adding a * below. But it will make things a tiny bit more efficient.
Note You need to log in before you can comment on or make changes to this bug.