Bug 215482 - RTL: volume slider and icons are backwards
Summary: RTL: volume slider and icons are backwards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-13 17:30 PDT by Devin Rousso
Modified: 2020-08-14 15:14 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.00 KB, patch)
2020-08-13 17:36 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (9.81 KB, patch)
2020-08-14 14:21 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-08-13 17:30:22 PDT
.
Comment 1 Devin Rousso 2020-08-13 17:30:35 PDT
<rdar://problem/65730749>
Comment 2 Devin Rousso 2020-08-13 17:36:19 PDT
Created attachment 406559 [details]
Patch
Comment 3 Peng Liu 2020-08-13 22:27:08 PDT
Looks like some layout tests need to be updated. :-)
Comment 4 Devin Rousso 2020-08-13 22:56:41 PDT
(In reply to Peng Liu from comment #3)
> Looks like some layout tests need to be updated. :-)
... that is surprising given that nothing should change for LTR o.0
Comment 5 Eric Carlson 2020-08-14 12:41:30 PDT
Comment on attachment 406559 [details]
Patch

The test failure looks real. 

r=me once the bots are happy.
Comment 6 Devin Rousso 2020-08-14 14:21:28 PDT
Created attachment 406619 [details]
Patch

fix failing tests
Comment 7 EWS 2020-08-14 15:14:27 PDT
Committed r265709: <https://trac.webkit.org/changeset/265709>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406619 [details].