Bug 215466 - [WebGL2] Skip buggy conformance tests
Summary: [WebGL2] Skip buggy conformance tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-13 15:05 PDT by James Darpinian
Modified: 2021-03-09 20:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2020-08-13 15:06 PDT, James Darpinian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-08-13 15:05:44 PDT 
[WebGL2] Skip buggy conformance tests
Comment 1 James Darpinian 2020-08-13 15:06:38 PDT 
Created attachment 406546 [details]
Patch
Comment 2 James Darpinian 2020-08-13 15:10:01 PDT 
Comment on attachment 406546 [details]
Patch

This should fix the deqp bot so it finishes a complete run every time instead of stopping halfway. https://build.webkit.org/builders/Apple-Catalina-Debug-WK2-WebGL-Tests
Comment 3 EWS 2020-08-14 15:30:38 PDT 
Committed r265710: <https://trac.webkit.org/changeset/265710>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406546 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-14 15:31:22 PDT 
<rdar://problem/67102040>
Comment 5 Kimmo Kinnunen 2021-03-09 03:12:33 PST 
Do we remember why the LayoutTests/webgl/TestExpectations added tests without deqp prefix?
I'd imagine those skips would be added to LayoutTests/TestExpectations
Comment 6 Kenneth Russell 2021-03-09 20:15:17 PST 
Sorry, I'm not sure. Agree it's confusing that most of the webgl/ expectations are in LayoutTests/TestExpectations and some in LayoutTests/webgl/TestExpectations .

Maybe some of the WebKit EWS bots are configured to run or ignore some of these tests / TestExpectations and that's why they're factored this way?