Bug 215453 - REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted"
Summary: REGRESSION (r260684): Messages YouTube inline video: after Multitasking away ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 211003
  Show dependency tree / graph
 
Reported: 2020-08-13 09:20 PDT by Chris Dumez
Modified: 2024-01-25 17:58 PST (History)
15 users (show)

See Also:

Attachments
Patch (14.85 KB, patch)
2020-08-13 10:20 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.29 KB, patch)
2020-08-13 11:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.40 KB, patch)
2020-08-13 11:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (15.24 KB, patch)
2020-08-13 11:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-13 09:20:03 PDT 
Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted". This is a regression from <https://trac.webkit.org/changeset/260684/webkit>.
Comment 1 Chris Dumez 2020-08-13 09:20:11 PDT 
<rdar://problem/66136673>
Comment 2 Chris Dumez 2020-08-13 10:20:25 PDT 
Created attachment 406522 [details]
Patch
Comment 3 Peng Liu 2020-08-13 10:37:14 PDT 
Comment on attachment 406522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review

> Source/WebCore/ChangeLog:12
> +        events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is

"silence" here means "drop" messages/events?
Comment 4 Chris Dumez 2020-08-13 10:38:53 PDT 
(In reply to Peng Liu from comment #3)
> Comment on attachment 406522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406522&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is
> 
> "silence" here means "drop" messages/events?

Yes, those messages were getting dropped indeed.
Comment 5 Tim Horton 2020-08-13 11:16:38 PDT 
Comment on attachment 406522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:1734
> +    void setIsDoingSnapshotSequence(bool);

"IsDoing" sounds a bit funny, and "snapshot sequence" sounds a bit vague (what kind of snapshot? we do so many kinds).

isSnapshottingForApplicationSuspension, maybe?
Comment 6 Geoffrey Garen 2020-08-13 11:20:51 PDT 
> isSnapshottingForApplicationSuspension, maybe?

isTakingSnapshotForApplicationSuspension?
Comment 7 Tim Horton 2020-08-13 11:23:46 PDT 
(In reply to Geoffrey Garen from comment #6)
> > isSnapshottingForApplicationSuspension, maybe?
> 
> isTakingSnapshotForApplicationSuspension?

Sure!
Comment 8 Chris Dumez 2020-08-13 11:43:42 PDT 
Created attachment 406525 [details]
Patch
Comment 9 Chris Dumez 2020-08-13 11:53:06 PDT 
Created attachment 406527 [details]
Patch
Comment 10 Chris Dumez 2020-08-13 11:53:35 PDT 
Comment on attachment 406527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406527&action=review

> Source/WebCore/page/Quirks.cpp:648
> +#if PLATFORM(IOS)

Added this check since we only need those quirks on iOS.
Comment 11 Chris Dumez 2020-08-13 11:56:45 PDT 
Created attachment 406528 [details]
Patch
Comment 12 EWS 2020-08-13 14:50:36 PDT 
Committed r265623: <https://trac.webkit.org/changeset/265623>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406528 [details].