Bug 215453 – REGRESSION (r260684): Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted"

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Messages YouTube inline video: after Multitasking away and Back, Audio is heard but icon indicates "muted". This is a regression from <https://trac.webkit.org/changeset/260684/webkit>.

[Chris Dumez]

<rdar://problem/66136673>

[Chris Dumez]

Created attachment 406522 [details]
Patch

[Peng Liu]

Comment on attachment 406522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review

> Source/WebCore/ChangeLog:12
> +        events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is

"silence" here means "drop" messages/events?

[Chris Dumez]

(In reply to Peng Liu from comment #3)
> Comment on attachment 406522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406522&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        events which have nothing to do with the snapshot sequence, like window.postMessage()'s message events. This is
> 
> "silence" here means "drop" messages/events?

Yes, those messages were getting dropped indeed.

[Tim Horton]

Comment on attachment 406522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406522&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.h:1734
> +    void setIsDoingSnapshotSequence(bool);

"IsDoing" sounds a bit funny, and "snapshot sequence" sounds a bit vague (what kind of snapshot? we do so many kinds).

isSnapshottingForApplicationSuspension, maybe?

[Geoffrey Garen]

> isSnapshottingForApplicationSuspension, maybe?

isTakingSnapshotForApplicationSuspension?

[Tim Horton]

(In reply to Geoffrey Garen from comment #6)
> > isSnapshottingForApplicationSuspension, maybe?
> 
> isTakingSnapshotForApplicationSuspension?

Sure!

[Chris Dumez]

Created attachment 406525 [details]
Patch

[Chris Dumez]

Created attachment 406527 [details]
Patch

[Chris Dumez]

Comment on attachment 406527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406527&action=review

> Source/WebCore/page/Quirks.cpp:648
> +#if PLATFORM(IOS)

Added this check since we only need those quirks on iOS.

[Chris Dumez]

Created attachment 406528 [details]
Patch

[EWS]

Committed r265623: <https://trac.webkit.org/changeset/265623>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406528 [details].