Bug 215449 - [ews] Improve wording for test failure email
Summary: [ews] Improve wording for test failure email
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-13 07:17 PDT by Aakash Jain
Modified: 2020-08-13 09:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2020-08-13 07:20 PDT, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-13 07:17:23 PDT 
Improve wording for test failure emails by EWS.
Comment 1 Aakash Jain 2020-08-13 07:20:15 PDT 
Created attachment 406512 [details]
Patch
Comment 2 Jonathan Bedard 2020-08-13 08:45:08 PDT 
Comment on attachment 406512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2159
> +            email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id)

Should we link the patch ID to bugzilla?
Comment 3 Aakash Jain 2020-08-13 08:57:35 PDT 
Comment on attachment 406512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:2159
>> +            email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id)
> 
> Should we link the patch ID to bugzilla?

Good idea, let me do that in subsequent patch.
Comment 4 Aakash Jain 2020-08-13 08:59:37 PDT 
Committed r265609: <https://trac.webkit.org/changeset/265609>
Comment 5 Radar WebKit Bug Importer 2020-08-13 09:00:26 PDT 
<rdar://problem/66994254>
Comment 6 Aakash Jain 2020-08-13 09:34:52 PDT 
> > Should we link the patch ID to bugzilla?
> 
> Good idea, let me do that in subsequent patch.
Doing it in Bug 215455.