Bug 215443 - Move scroll / overflow handling out of RenderLayer
Summary: Move scroll / overflow handling out of RenderLayer
Status: RESOLVED DUPLICATE of bug 60305
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-13 01:04 PDT by Nikolas Zimmermann
Modified: 2020-08-13 16:05 PDT (History)
27 users (show)

See Also:

Attachments
Patch (320.21 KB, patch)
2020-08-13 01:11 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch (317.65 KB, patch)
2020-08-13 07:36 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Patch (319.64 KB, patch)
2020-08-13 14:54 PDT, Nikolas Zimmermann 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2020-08-13 01:04:25 PDT 
Per recent discussions between Igalia / Apple, it would be nice to split up RenderLayer into a lean, base class and a derived class which contains all scroll / overflow handling ("RenderLayerScrollable").

I propose to first move all scroll / overflow handling from RenderLayer to RenderLayerScrollable, and as next step only create RenderLayerScrollable objects if needed -- this should be a performance progression for many scenarios.

I'll upload an initial draft patch to discuss the design.
Comment 1 Nikolas Zimmermann 2020-08-13 01:11:40 PDT 
Created attachment 406501 [details]
Patch
Comment 2 Nikolas Zimmermann 2020-08-13 01:14:12 PDT 
Eww 320k :-( The majority of the patch size is moving methods 1:1, unmodified, from RenderLayer to RenderLayerScrollable.

@smfr, would be nice if you could have a look at the general design.
I'm open for improvements, as always!
Comment 3 Nikolas Zimmermann 2020-08-13 07:35:55 PDT 
Needs some iterations, I likely missed win/ios/mac specific build fixes.
Comment 4 Nikolas Zimmermann 2020-08-13 07:36:58 PDT 
Created attachment 406515 [details]
Patch
Comment 5 Nikolas Zimmermann 2020-08-13 14:54:15 PDT 
Created attachment 406545 [details]
Patch
Comment 6 Simon Fraser (smfr) 2020-08-13 15:01:10 PDT 
Please dup this bug to 60305 and continue work there.
Comment 7 Nikolas Zimmermann 2020-08-13 16:05:09 PDT 

*** This bug has been marked as a duplicate of bug 60305 ***