Bug 215440 - Add settings for Copy WebKit Permalink
Summary: Add settings for Copy WebKit Permalink
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 215796
  Show dependency tree / graph
 
Reported: 2020-08-12 21:27 PDT by Devin Rousso
Modified: 2020-08-24 21:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2020-08-12 21:34 PDT, Devin Rousso 		dbates: review+
Details | Formatted Diff | Diff
Patch (6.18 KB, patch)
2020-08-12 22:21 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-08-12 21:27:55 PDT 
.
Comment 1 Devin Rousso 2020-08-12 21:34:03 PDT 
Created attachment 406495 [details]
Patch
Comment 2 Devin Rousso 2020-08-12 21:47:40 PDT 
Comment on attachment 406495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review

> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3
> +    "include_revision": true,

I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality.
Comment 3 Daniel Bates 2020-08-12 22:03:41 PDT 
Comment on attachment 406495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406495&action=review

Patch looks good.

> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:38
> +class Settings:

Ok as is. Consider inherit from object.

>> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3
>> +    "include_revision": true,
> 
> I was tempted to have this default to `false` as it's significantly more performant for me, but I erred on the side of caution in preserving existing functionality.

👍
Comment 4 Devin Rousso 2020-08-12 22:21:42 PDT 
Created attachment 406498 [details]
Patch
Comment 5 EWS 2020-08-12 23:07:01 PDT 
Committed r265601: <https://trac.webkit.org/changeset/265601>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406498 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-12 23:07:17 PDT 
<rdar://problem/66963933>