RESOLVED FIXED Bug 215426
[PlayStation] Build fix for !ENABLE(ACCESSIBILITY) after r265514 
https://bugs.webkit.org/show_bug.cgi?id=215426
Summary [PlayStation] Build fix for !ENABLE(ACCESSIBILITY) after r265514
Stephan Szabo
Reported 2020-08-12 13:32:45 PDT
r265514 changed a name but not a reference in the !ENABLE(ACCESSIBILITY) code in AXObjectCache.h.
Attachments
Patch (1.75 KB, patch)
2020-08-12 13:38 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-08-12 13:38:02 PDT
Created attachment 406471 [details] Patch
EWS
Comment 2 2020-08-12 14:31:50 PDT
Committed r265564: <https://trac.webkit.org/changeset/265564> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406471 [details].
Radar WebKit Bug Importer
Comment 3 2020-08-12 14:32:40 PDT
<rdar://problem/66934803>
Darin Adler
Comment 4 2020-08-12 16:14:07 PDT
Two thoughts: 1) Seems like we should find a cleaner way to support !ENABLE(ACCESSIBILITY). The current way is complex to maintain. Or get rid of the notion entirely and intentionally write a platform-specific stub rather than having the platform-independent code contain a stub. There are *so* many functions stubbed out! 2) None of the EWS builds are !ENABLE(ACCESSIBILITY). What can we do about that?
Stephan Szabo
Comment 5 2020-08-12 16:44:18 PDT
For #1, I was also wondering if having the enable flag actually made sense any more. I wasn't really sure if there were other targets for set top boxes or anything that might have it off, because even for PlayStation, it will be getting enabled, so it could end up on everywhere.
Note You need to log in before you can comment on or make changes to this bug.