Bug 215423 - Check com.apple.private.webkit.use-xpc-endpoint only on internal builds
Summary: Check com.apple.private.webkit.use-xpc-endpoint only on internal builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-12 13:07 PDT by Saagar Jha
Modified: 2020-11-17 13:03 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.99 KB, patch)
2020-08-12 13:14 PDT, Saagar Jha
pvollan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2020-11-17 11:50 PST, Per Arne Vollan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2020-11-17 11:55 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saagar Jha 2020-08-12 13:07:52 PDT
Check com.apple.private.webkit.use-xpc-endpoint only on internal builds
Comment 1 Saagar Jha 2020-08-12 13:14:26 PDT
Created attachment 406468 [details]
Patch
Comment 2 Saagar Jha 2020-08-17 15:25:26 PDT
https://bugs.webkit.org/show_bug.cgi?id=215569 looks related but it just increases the timeout and only waits on first launch, which I think is still problematic because as far as I can tell the process never connects at all.
Comment 3 Per Arne Vollan 2020-08-17 16:21:24 PDT
Comment on attachment 406468 [details]
Patch

R=me.
Comment 4 Radar WebKit Bug Importer 2020-08-19 13:08:43 PDT
<rdar://problem/67421536>
Comment 5 EWS 2020-11-17 06:36:25 PST
Tools/Scripts/svn-apply failed to apply attachment 406468 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Per Arne Vollan 2020-11-17 11:50:08 PST
Created attachment 414361 [details]
Patch
Comment 7 Per Arne Vollan 2020-11-17 11:55:32 PST
Created attachment 414362 [details]
Patch
Comment 8 EWS 2020-11-17 12:25:36 PST
Committed r269917: <https://trac.webkit.org/changeset/269917>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414362 [details].