Bug 21542 - CSS NS resolvers are no longer part of the spec
Summary: CSS NS resolvers are no longer part of the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Minor
Assignee: Sam Weinig
URL: http://dev.w3.org/2006/webapi/selecto...
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2008-10-10 20:27 PDT by Dimitri Glazkov (Google)
Modified: 2008-10-14 12:55 PDT (History)
3 users (show)

See Also:


Attachments
Removes NS Resolver functionality from Node.cpp and friends (205.68 KB, patch)
2008-10-13 07:37 PDT, Dimitri Glazkov (Google)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2008-10-10 20:27:02 PDT
Since the NS resolvers were recently removed from the spec, I thought I'd take on cleaning up the code.
Comment 1 Sam Weinig 2008-10-10 20:29:49 PDT
Removing them should be quite trivial, the trick is what to do with the tests :).
Comment 2 Dimitri Glazkov (Google) 2008-10-13 07:37:30 PDT
Created attachment 24313 [details]
Removes NS Resolver functionality from Node.cpp and friends

Struggled a bit figuring out how to produce a diff for the patch using git. Aye caramba, I have much to learn :)
Comment 3 Sam Weinig 2008-10-13 10:22:30 PDT
Comment on attachment 24313 [details]
Removes NS Resolver functionality from Node.cpp and friends

+    // throw a NAMESPACE_ERR if the selector includes any namespace prefixes.
Should use a capital T for throw, at least to be consistent.

How sad.  That code was so fun to write :(.

r=me
Comment 4 Adam Barth 2008-10-14 01:24:28 PDT
I would land this, but its too big and scary.
Comment 5 Sam Weinig 2008-10-14 08:38:59 PDT
I'll land this.
Comment 6 Sam Weinig 2008-10-14 12:55:58 PDT
Landed in r37590.