RESOLVED FIXED 215418
Add Copy WebKit Permalink items to Sublime Text command palette
https://bugs.webkit.org/show_bug.cgi?id=215418
Summary Add Copy WebKit Permalink items to Sublime Text command palette
Devin Rousso
Reported 2020-08-12 11:34:27 PDT
I use this all the time, and it would be nice to have a a way to invoke "Copy WebKit Permalink" without having to right-click :)
Attachments
Patch (2.67 KB, patch)
2020-08-12 11:37 PDT, Devin Rousso
no flags
Devin Rousso
Comment 1 2020-08-12 11:37:08 PDT
Keith Miller
Comment 2 2020-08-12 11:41:18 PDT
Comment on attachment 406466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review rs=me > Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 > + { "caption": "Copy WebKit Permalink", "command": "copy_web_kit_permalink" }, > + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing?
Devin Rousso
Comment 3 2020-08-12 11:46:53 PDT
Comment on attachment 406466 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406466&action=review >> Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-commands:3 >> + { "caption": "Copy WebKit Permalink to Blame", "command": "copy_web_kit_permalink", "args": { "annotate_blame": true } }, > > What's with the underscores between web and kit? Don't we normally use one word even when not capitalizing? I believe Sublime Text snakecases any `sublime_plugin.Command` using capital letters as delimiters. I don't know if it's possible to control over that. FWIW this is what `Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu` does too ¯\_(ツ)_/¯
EWS
Comment 4 2020-08-12 12:21:14 PDT
Committed r265557: <https://trac.webkit.org/changeset/265557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406466 [details].
Radar WebKit Bug Importer
Comment 5 2020-08-12 12:22:19 PDT
Note You need to log in before you can comment on or make changes to this bug.