Bug 215417 - Add support for suspending / resuming an OfflineAudioContext
Summary: Add support for suspending / resuming an OfflineAudioContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-12 10:43 PDT by Chris Dumez
Modified: 2020-08-14 13:28 PDT (History)
12 users (show)

See Also:

Attachments
WIP Patch (22.13 KB, patch)
2020-08-12 10:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (182.71 KB, patch)
2020-08-13 15:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (185.65 KB, patch)
2020-08-13 16:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (185.69 KB, patch)
2020-08-13 16:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (253.24 KB, patch)
2020-08-14 12:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-12 10:43:08 PDT 
Add support for suspending / resuming an OfflineAudioContext.
Comment 1 Chris Dumez 2020-08-12 10:44:02 PDT 
Created attachment 406464 [details]
WIP Patch
Comment 2 Chris Dumez 2020-08-13 15:26:49 PDT 
Created attachment 406547 [details]
Patch
Comment 3 Chris Dumez 2020-08-13 16:01:56 PDT 
Created attachment 406551 [details]
Patch
Comment 4 Chris Dumez 2020-08-13 16:10:04 PDT 
Created attachment 406552 [details]
Patch
Comment 5 Eric Carlson 2020-08-14 11:31:55 PDT 
Comment on attachment 406552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406552&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:659
>      // Don't allow regular lock in real-time audio thread.

This comment is not accurate when shouldAllowLockingOnAudioThread == ShouldAllowLockingOnAudioThread::Yes

> Source/WebCore/Modules/webaudio/BaseAudioContext.h:208
> +    enum class ShouldAllowLockingOnAudioThread { No, Yes };

It seems like there should be a comment here with a stern warning about using this.
Comment 6 Chris Dumez 2020-08-14 12:41:10 PDT 
Created attachment 406615 [details]
Patch
Comment 7 EWS 2020-08-14 13:27:12 PDT 
Committed r265701: <https://trac.webkit.org/changeset/265701>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406615 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-14 13:28:23 PDT 
<rdar://problem/67093628>