Bug 215409 – getPropertyValue for url path doesn't return the "#" character

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Thien]

When calling getPropertyValue of a property that is a url(...) pointing to another element (common in SVG), the result is returned without the "#" part.

For example, the CSS:

```
marker-mid: url(#dot)
```

The returned string in:
- Firefox 79: "url(#dot)"
- Chrome 84: "url(#dot)"
- Safari 13: "url(dot)"

Demo: https://codesandbox.io/s/modest-moon-z98tr?file=/index.html

[Radar WebKit Bug Importer]

<rdar://problem/66919778>

[Rob Buis]

Created attachment 427495 [details]
Patch

[Rob Buis]

Created attachment 427523 [details]
Patch

[EWS]

Committed r276888 (237234@main): <https://commits.webkit.org/237234@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427523 [details].

[Darin Adler]

Comment on attachment 427523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427523&action=review

> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:125
> +            return CSSPrimitiveValue::create(makeString('#', svgStyle.maskerResource()), CSSUnitType::CSS_URI);

More efficient because it uses '#'.

> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:139
> +            return CSSPrimitiveValue::create(makeString("#", svgStyle.markerEndResource()), CSSUnitType::CSS_URI);

Slightly less efficient because it uses "#". Should be consistent.

[Rob Buis]

Reopening to attach new patch.

[Rob Buis]

Created attachment 427542 [details]
Patch

[Rob Buis]

Comment on attachment 427523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427523&action=review

>> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:125
>> +            return CSSPrimitiveValue::create(makeString('#', svgStyle.maskerResource()), CSSUnitType::CSS_URI);
> 
> More efficient because it uses '#'.

I see.

>> Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:139
>> +            return CSSPrimitiveValue::create(makeString("#", svgStyle.markerEndResource()), CSSUnitType::CSS_URI);
> 
> Slightly less efficient because it uses "#". Should be consistent.

I intended to at least be consistent but failed there, so I made a fix-up patch.

[EWS]

Committed r276894 (237240@main): <https://commits.webkit.org/237240@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427542 [details].