Bug 215400 - Web Inspector: remove error-prone WI.UIString variant that takes two arguments
Summary: Web Inspector: remove error-prone WI.UIString variant that takes two arguments
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-11 16:07 PDT by Blaze Burg
Modified: 2020-08-19 13:08 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Blaze Burg 2020-08-11 16:07:42 PDT 
.
Comment 1 Nikita Vasilyev 2020-08-11 16:09:22 PDT 
Note that `(string, comment)` combo is pretty common. I got 34 matches when I searched using `WI.UIString\("[^"]+", "[^"]+"\)` regex. You'd need to add 34 keys for those strings.
Comment 2 Radar WebKit Bug Importer 2020-08-18 16:08:16 PDT 
<rdar://problem/67359636>
Comment 3 Patrick Angle 2020-08-19 13:08:12 PDT 
For reference, the two argument variant for WI.UIString(...) was introduced in r245827.