Bug 215394 - Address locking concerns and other review feedback from r265502
Summary: Address locking concerns and other review feedback from r265502
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 214765
Blocks:
  Show dependency tree / graph
 
Reported: 2020-08-11 14:46 PDT by Kenneth Russell
Modified: 2020-08-11 15:05 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-08-11 14:46:04 PDT 
ysuzuki@ provided review feedback for Bug 214765 after the patch was landed which needs to be addressed.

The most significant concern is that locking is needed around some object traversals since GC marking can occur concurrently to the main thread. However, these objects represent a tree structure and it's not immediately clear how to organize such a lock.
Comment 1 Kenneth Russell 2020-08-11 15:05:16 PDT 
Reverted the patch because of the potential for multithreading-related GC craghes. Will address this feedback in the parent bug.