--inspector-frontend is for engineers' use and should not compile non-inspector stuff.
<rdar://problem/66862975>
Created attachment 406422 [details] Patch
Comment on attachment 406422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review > Tools/Scripts/build-webkit:372 > + if (isInspectorFrontend()) { > + exit exitStatus($result); > + } This *is* perl, so you could us the perl one-liner style.
Comment on attachment 406422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review >> Tools/Scripts/build-webkit:372 >> + } > > This *is* perl, so you could us the perl one-liner style. use (or not, or rewrite the script in Python)
This should be fine, WebInspector's front-end is a configuration I overlooked when adding the code Brian is skipping, this should be safe!
(In reply to Darin Adler from comment #4) > Comment on attachment 406422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406422&action=review > > >> Tools/Scripts/build-webkit:372 > >> + } > > > > This *is* perl, so you could us the perl one-liner style. > > use > > (or not, or rewrite the script in Python) I have successfully resisted the urge for 8 years. 😅
Committed r265537: <https://trac.webkit.org/changeset/265537> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406422 [details].
Comment on attachment 406422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406422&action=review >>>> Tools/Scripts/build-webkit:372 >>>> + } >>> >>> This *is* perl, so you could us the perl one-liner style. >> >> use >> >> (or not, or rewrite the script in Python) > > I have successfully resisted the urge for 8 years. 😅 I haven't ;) I'm using a local Python port of build-webkit. It's very minimal though. Re-implementing all the features of the Perl version would be a large task :(
(In reply to Philippe Normand from comment #8) > Comment on attachment 406422 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406422&action=review > > >>>> Tools/Scripts/build-webkit:372 > >>>> + } > >>> > >>> This *is* perl, so you could us the perl one-liner style. > >> > >> use > >> > >> (or not, or rewrite the script in Python) > > > > I have successfully resisted the urge for 8 years. 😅 > > I haven't ;) I'm using a local Python port of build-webkit. It's very > minimal though. Re-implementing all the features of the Perl version would > be a large task :( I don't think anyone would object to checking in what you have (as long as it's named something else and clearly marked as experimental). It's easier to improve once it's been shared ;-)