Bug 215378 - Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
Summary: Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-11 09:02 PDT by youenn fablet
Modified: 2020-08-11 10:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2020-08-11 09:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2020-08-11 09:20 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-11 09:02:26 PDT 
Cherry-pick usrsctp 264ce452885bfed73348ba6b6f63693bc2f52a6e commit
Comment 1 youenn fablet 2020-08-11 09:03:10 PDT 
<rdar://problem/66788144>
Comment 2 youenn fablet 2020-08-11 09:04:06 PDT 
Created attachment 406384 [details]
Patch
Comment 3 Eric Carlson 2020-08-11 09:07:03 PDT 
Comment on attachment 406384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review

> Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722
> +            return;

Nit: the indentation is strange.
Comment 4 youenn fablet 2020-08-11 09:18:07 PDT 
Comment on attachment 406384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406384&action=review

>> Source/ThirdParty/libwebrtc/Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:722
>> +            return;
> 
> Nit: the indentation is strange.

Ah, I used space but this file is using tabs...
Comment 5 youenn fablet 2020-08-11 09:20:17 PDT 
Created attachment 406385 [details]
Patch
Comment 6 EWS 2020-08-11 10:06:35 PDT 
Committed r265500: <https://trac.webkit.org/changeset/265500>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406385 [details].