RESOLVED FIXED 215370
Add JS console log message in case of capture failure
https://bugs.webkit.org/show_bug.cgi?id=215370
Summary Add JS console log message in case of capture failure
youenn fablet
Reported 2020-08-11 05:53:07 PDT
Add JS console log message in case of capture failure
Attachments
Patch (2.65 KB, patch)
2020-08-11 05:59 PDT, youenn fablet
no flags
youenn fablet
Comment 1 2020-08-11 05:59:15 PDT
Eric Carlson
Comment 2 2020-08-11 07:14:05 PDT
Comment on attachment 406376 [details] Patch Thanks!
EWS
Comment 3 2020-08-11 10:07:35 PDT
Committed r265501: <https://trac.webkit.org/changeset/265501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406376 [details].
Radar WebKit Bug Importer
Comment 4 2020-08-11 10:08:16 PDT
Devin Rousso
Comment 5 2020-08-14 13:51:33 PDT
Comment on attachment 406376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406376&action=review > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:539 > + scriptExecutionContext()->addConsoleMessage(MessageSource::JS, MessageLevel::Error, "A MediaStreamTrack ended due to a capture failure"_s); For future reference, this probably should've used `MessageSource::Media` or `MessageSource::MediaStream`. `MessageSource::JS` is supposed to be for "this comes from JavaScript language logic".
Note You need to log in before you can comment on or make changes to this bug.