ASSIGNED 215358
Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlock*.
https://bugs.webkit.org/show_bug.cgi?id=215358
Summary Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlo...
Mark Lam
Reported 2020-08-10 22:44:23 PDT
There's no need to return an Exception*. The canonical way to get the Exception* is from a ThrowScope. This non-canonical idiom of returning an Exception* here can result in bugs e.g. https://bugs.webkit.org/show_bug.cgi?id=215357.
Attachments
proposed patch. (3.76 KB, patch)
2020-08-10 22:55 PDT, Mark Lam
no flags
Mark Lam
Comment 1 2020-08-10 22:55:58 PDT Comment hidden (obsolete)
Mark Lam
Comment 2 2020-08-10 23:00:12 PDT Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 3 2020-08-17 22:45:14 PDT
Note You need to log in before you can comment on or make changes to this bug.