WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
215358
Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlock*.
https://bugs.webkit.org/show_bug.cgi?id=215358
Summary
Consider changing ScriptExecutable::prepareForExecution() to return a CodeBlo...
Mark Lam
Reported
2020-08-10 22:44:23 PDT
There's no need to return an Exception*. The canonical way to get the Exception* is from a ThrowScope. This non-canonical idiom of returning an Exception* here can result in bugs e.g.
https://bugs.webkit.org/show_bug.cgi?id=215357
.
Attachments
proposed patch.
(3.76 KB, patch)
2020-08-10 22:55 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2020-08-10 22:55:58 PDT
Comment hidden (obsolete)
Created
attachment 406362
[details]
proposed patch.
Mark Lam
Comment 2
2020-08-10 23:00:12 PDT
Comment hidden (obsolete)
Comment on
attachment 406362
[details]
proposed patch. Submitted patch to wrong bug. Sorry.
Radar WebKit Bug Importer
Comment 3
2020-08-17 22:45:14 PDT
<
rdar://problem/67298086
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug