Bug 215342 – Web Inspector: add aria-label for [>>] overflow tab picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect any page
2. detach/undock Web Inspector
3. make the Web Inspector window very small horizontally/width-wis
4. hover over the [>>] overflow tab picker
  => [>>] overflow tab picker has no tooltip

[Radar WebKit Bug Importer]

<rdar://problem/66804113>

[Nikita Vasilyev]

On Big Sur, Safari and Finder both show ">>" icon for their toolbars and it doesn't have a tooltip.

[Nikita Vasilyev]

When VoiceOver is enabled, it reads "More toolbar items".
I think we should add aria-label with "More tab items" or, perhaps, "More tabs".

[Devin Rousso]

(In reply to Nikita Vasilyev from comment #2)
> On Big Sur, Safari and Finder both show ">>" icon for their toolbars and it doesn't have a tooltip.

Regardless of whether the rest of the system has a tooltip, I think we should have one.  Our tab bar is different enough from the rest of the system that we should be as clear as possible wherever we can be.

[Patrick Angle]

Created attachment 406593 [details]
Patch

[Devin Rousso]

Comment on attachment 406593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406593&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        * UserInterface/Views/PinnedTabBarItem.js: `displayName` is now used to set the `aria-label` for pinned tabs

This is going to "clash" with the Search Tab and Settings Tab which already have `title` attributes.  I think a simpler solution would just be to provide a `title` argument when creating the overflow tab picker:
```diff
-this._tabPickerTabBarItem = new WI.PinnedTabBarItem(tabPickerRepresentedObject, "Images/TabPicker.svg", WI.UIString("Show hidden tabs"));
+const tabPickerDisplayName = null;
+this._tabPickerTabBarItem = new WI.PinnedTabBarItem(tabPickerRepresentedObject, "Images/TabPicker.svg", tabPickerDisplayName, WI.UIString("Show hidden tabs"));
```

[Patrick Angle]

Created attachment 406607 [details]
Patch

[Devin Rousso]

Comment on attachment 406607 [details]
Patch

r=me, thanks for iterating :)

[Nikita Vasilyev]

Comment on attachment 406607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406607&action=review

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: add aria-label for [>>] overflow tab picker

This doesn't correspond to the actual change. Please retitle the bug in Bugzilla before generating the changelog going forward.

[EWS]

Committed r265682: <https://trac.webkit.org/changeset/265682>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406607 [details].