Bug 215333 - Shaping can be performed on glyphIDs from the wrong font
Summary: Shaping can be performed on glyphIDs from the wrong font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 206208 215059
  Show dependency tree / graph
 
Reported: 2020-08-10 13:01 PDT by Myles C. Maxfield
Modified: 2020-08-10 14:53 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.23 KB, patch)
2020-08-10 13:11 PDT, Myles C. Maxfield 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-08-10 13:01:19 PDT 
Shaping can be performed on glyphIDs from the wrong font
Comment 1 Myles C. Maxfield 2020-08-10 13:11:21 PDT 
Created attachment 406322 [details]
Patch
Comment 2 Darin Adler 2020-08-10 13:18:30 PDT 
Comment on attachment 406322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406322&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:181
> +            const GlyphData& uppercaseGlyphData = m_font.glyphDataForCharacter(u_toupper(character), m_run.rtl());

I suggest we use "auto&" here and/or have the local variable be the font instead of the glyph data:

    auto glyphFont = m_font.glyphDataForCharacter(u_toupper(character), m_run.rtl()).font;
Comment 3 Myles C. Maxfield 2020-08-10 14:52:07 PDT 
Committed r265455: <https://trac.webkit.org/changeset/265455>
Comment 4 Radar WebKit Bug Importer 2020-08-10 14:53:37 PDT 
<rdar://problem/66801199>