Bug 215320 - Return values of FontDatabase::collectionForFamily are not thread safe
Summary: Return values of FontDatabase::collectionForFamily are not thread safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-10 05:12 PDT by Antti Koivisto
Modified: 2020-08-10 09:41 PDT (History)
6 users (show)

See Also:

Attachments
patch (3.25 KB, patch)
2020-08-10 05:26 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-08-10 05:12:40 PDT 
This results in a crash under findClosestFont:

   50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) <==
        50 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest)
          50 WebCore: WebCore::FontCache::createFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities)
            50 WebCore: WebCore::FontCache::getCachedFontPlatformData(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool)
              50 WebCore: WebCore::FontCache::fontForFamily(WebCore::FontDescription const&, WTF::AtomString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontSelectionSpecifiedCapabilities, bool)
                50 WebCore: WebCore::CSSFontSelector::fontRangesForFamily(WebCore::FontDescription const&, WTF::AtomString const&)
                  50 WebCore: WebCore::realizeNextFallback(WebCore::FontCascadeDescription const&, unsigned int&, WebCore::FontSelector*)
                    50 WebCore: WebCore::FontCascadeFonts::realizeFallbackRangesAt(WebCore::FontCascadeDescription const&, unsigned int)
                      50 WebCore: WebCore::FontCascadeFonts::primaryFont(WebCore::FontCascadeDescription const&)
Comment 1 Antti Koivisto 2020-08-10 05:13:55 PDT 
<rdar://problem/66502539>
Comment 2 Antti Koivisto 2020-08-10 05:26:20 PDT 
Created attachment 406293 [details]
patch
Comment 3 EWS 2020-08-10 09:41:52 PDT 
Committed r265432: <https://trac.webkit.org/changeset/265432>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406293 [details].