Bug 215319 - REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
Summary: REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-10 00:36 PDT by Tim Horton
Modified: 2020-08-10 10:59 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2020-08-10 00:37 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-08-10 00:36:32 PDT 
REGRESSION (r265176): Cannot make or extend selections in iOS WebKitLegacy
Comment 1 Tim Horton 2020-08-10 00:37:01 PDT 
Created attachment 406286 [details]
Patch
Comment 2 Tim Horton 2020-08-10 00:37:04 PDT 
<rdar://problem/66688560>
Comment 3 Devin Rousso 2020-08-10 00:38:37 PDT 
Comment on attachment 406286 [details]
Patch

r=mews
Comment 4 EWS 2020-08-10 01:18:07 PDT 
Committed r265424: <https://trac.webkit.org/changeset/265424>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406286 [details].
Comment 5 Darin Adler 2020-08-10 10:59:38 PDT 
Comment on attachment 406286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406286&action=review

> Source/WebKitLegacy/ios/ChangeLog:12
> +        * WebCoreSupport/WebVisiblePosition.mm:
> +        (+[DOMRange rangeForFirstPosition:second:]):
> +        We want to ensure that firstPosition is *before* secondPosition, so
> +        the change in r265176 got the condition backwards. Swap it.

So sorry! I should make a regression test.