Bug 21531 – svg/carto.net/window.svg has race condition

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Pam Greene (IRC:pamg)]

The svg/carto.net/window.svg test has a race. It adds a window decoration to one of the windows when its create function is called via setTimeout.  If the app is fast, the create function is not called before the tree is dumped, and the decoration is not added. However, when the app is slow enough, enough time may pass that the create function is called and the decoration is added.

This nondeterminism should be fixed by modifying the test to wait until all create functions have been called before terminating.

[Pam Greene (IRC:pamg)]

Created attachment 24275 [details]
Fixes race + new results

[Darin Adler]

Comment on attachment 24275 [details]
Fixes race + new results

rs=me

[Sam Weinig]

+        // WebKit modification: do not terminate before all create functions
I don't think it makes sense to include "WebKit modification: " part.

[Adam Barth]

I'll land this.

[Adam Barth]

Fixed r37544.

[Pam Greene (IRC:pamg)]

(In reply to comment #3)
> +        // WebKit modification: do not terminate before all create functions
> I don't think it makes sense to include "WebKit modification: " part.

Are these tests not pulled in from somewhere else?  The directory structure led me to think so, but I don't know the history.

[Sam Weinig]

(In reply to comment #6)
> (In reply to comment #3)
> > +        // WebKit modification: do not terminate before all create functions
> > I don't think it makes sense to include "WebKit modification: " part.
> 
> Are these tests not pulled in from somewhere else?  The directory structure led
> me to think so, but I don't know the history.

I believe these tests are just based on examples from the carto.net site and are not meant to be merged back in the future.  The only time we need to worry about making too many changes to tests is if they are from an external test suite.