RESOLVED FIXED 21529
Test fast/js/function-toString-parentheses.html is broken when removesExtraParentheses == false 
https://bugs.webkit.org/show_bug.cgi?id=21529
Summary Test fast/js/function-toString-parentheses.html is broken when removesExtraPa...
Pam Greene (IRC:pamg)
Reported 2008-10-10 13:04:37 PDT
Test fast/js/function-toString-parentheses.html is broken when removesExtraParentheses == false. Since Safari uses removesExtraParentheses == true, this never showed up.
Attachments
Fixes test (11.71 KB, patch)
2008-10-10 13:21 PDT, Pam Greene (IRC:pamg) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1 2008-10-10 13:21:42 PDT
Created attachment 24273 [details] Fixes test Fixes the test to work properly no matter what the value of removesExtraParentheses is. Simplifies it by introducing two new helper functions, testKeepParentheses and testOptionalParentheses.
Darin Adler
Comment 2 2008-10-10 14:11:10 PDT
Comment on attachment 24273 [details] Fixes test The change is fine. But this test is far less useful now than when it was written because neither JavaScriptCore nor V8 really compile and serialize -- they both simply keep the original function text around. So they pass this. r=me
Adam Barth
Comment 3 2008-10-12 13:45:19 PDT
I'll land this.
Adam Barth
Comment 4 2008-10-12 18:57:56 PDT
Fixed in r37545.
Note You need to log in before you can comment on or make changes to this bug.