Bug 215265 - We should run the tests for DataMutex
Summary: We should run the tests for DataMutex
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-07 06:41 PDT by Robin Morisset
Modified: 2020-08-10 11:20 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.12 KB, patch)
2020-08-07 06:43 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (4.18 KB, patch)
2020-08-07 07:36 PDT, Robin Morisset 		mark.lam: review-
Details | Formatted Diff | Diff
Patch (5.06 KB, patch)
2020-08-10 01:45 PDT, Robin Morisset 		mark.lam: review-
mark.lam: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2020-08-07 06:41:43 PDT 
Tools/TestWebkitAPI/Tests/WTF/DataMutex.cpp exists, but it is not included in the building of the testWTF binary, and as a result is never run.
Fixing it is trivial.
Comment 1 Robin Morisset 2020-08-07 06:43:02 PDT 
Created attachment 406169 [details]
Patch
Comment 2 Robin Morisset 2020-08-07 07:36:49 PDT 
Created attachment 406173 [details]
Patch

rebased
Comment 3 Mark Lam 2020-08-08 00:19:40 PDT 
Comment on attachment 406173 [details]
Patch

r- for now.  Can you look into why the EWS bots are red?
Comment 4 Robin Morisset 2020-08-10 01:45:44 PDT 
Created attachment 406287 [details]
Patch

The EWS were red because some of our platforms don't support gtests'ASSERT_DEATH.
I made the tests that depend on this macro conditional on its support.
Comment 5 Mark Lam 2020-08-10 06:58:43 PDT 
Comment on attachment 406287 [details]
Patch

Thanks for fixing the failures.  Unfortunately, I don't think we should land this because grepping the code, I see that the DataMutex class is only used by the gtk port.  Unless we have a reason to include it (e.g. pending use), we should leave it out for Darwin ports.  You can close this bug as WONTFIX.
Comment 6 Robin Morisset 2020-08-10 11:20:28 PDT 
Ok.