Bug 215251 - Pocket City game play area is blank (WebGL is broken in Catalyst)
Summary: Pocket City game play area is blank (WebGL is broken in Catalyst)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-06 18:38 PDT by Dean Jackson
Modified: 2020-08-13 15:59 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2020-08-06 18:42 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-08-06 18:38:40 PDT 
Pocket City game play area is blank (WebGL is broken in Catalyst)
Comment 1 Dean Jackson 2020-08-06 18:39:31 PDT 
<rdar://63699436>
Comment 2 Dean Jackson 2020-08-06 18:42:42 PDT 
Created attachment 406146 [details]
Patch
Comment 3 Dean Jackson 2020-08-07 02:29:10 PDT 
Committed r265366: <https://trac.webkit.org/changeset/265366>
Comment 4 Darin Adler 2020-08-07 15:57:49 PDT 
Comment on attachment 406146 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406146&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:404
> +#if PLATFORM(MAC)

I suggest we try to avoid unnecessary #if nesting. Here we could have done an #endif above, then would not need two different #else below.
Comment 5 Dean Jackson 2020-08-13 15:58:04 PDT 
Fixed. Thanks Darin.
Comment 6 Dean Jackson 2020-08-13 15:59:40 PDT 
Committed r265635: <https://trac.webkit.org/changeset/265635>