Bug 21524 - Remove race condition in fast/encoding/script-in-head.html
Summary: Remove race condition in fast/encoding/script-in-head.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-10 10:46 PDT by Pam Greene (IRC:pamg)
Modified: 2008-10-12 18:58 PDT (History)
1 user (show)

See Also:


Attachments
Fixes test (1.68 KB, patch)
2008-10-10 10:49 PDT, Pam Greene (IRC:pamg)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pam Greene (IRC:pamg) 2008-10-10 10:46:43 PDT
The fast/encoding/script-in-head.html test has a race condition: the page may be dumped before the dynamically generated <script> tag is executed.  Likewise, the document.write() may be buffered, leading to unreliable results.  (Buffering document.write() may be a bug itself, but since it's not related to what this is testing, we should work around it here if we can.)
Comment 1 Pam Greene (IRC:pamg) 2008-10-10 10:49:00 PDT
Created attachment 24266 [details]
Fixes test

Expected results are unchanged.
Comment 2 Darin Adler 2008-10-10 14:04:40 PDT
Comment on attachment 24266 [details]
Fixes test

r=me
Comment 3 Adam Barth 2008-10-12 13:45:45 PDT
I'll land this.
Comment 4 Adam Barth 2008-10-12 18:58:48 PDT
Fixed in r37547.