WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21523
Add more test cases to fillrect_gradient.html
https://bugs.webkit.org/show_bug.cgi?id=21523
Summary
Add more test cases to fillrect_gradient.html
Pam Greene (IRC:pamg)
Reported
2008-10-10 09:56:46 PDT
fillrect_gradient.html could use a few more tests to cover more gradient edge cases.
Attachments
Expanded test + new results
(96.13 KB, patch)
2008-10-10 10:04 PDT
,
Pam Greene (IRC:pamg)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1
2008-10-10 10:04:35 PDT
Created
attachment 24263
[details]
Expanded test + new results Adds tests for missing endpoints and only one stop (at either end or in the middle). Makes the canvases smaller so they still all fit in the pixel test output.
Darin Adler
Comment 2
2008-10-10 14:01:58 PDT
Comment on
attachment 24263
[details]
Expanded test + new results Looks great, r=me By the way, Oliver Hunt has been suggesting that we do some new canvas tests that use getImageData and hence could be cross-platform dumpAsText tests. Please keep that in mind when doing further canvas testing.
Adam Barth
Comment 3
2008-10-12 13:45:56 PDT
I'll land this.
Adam Barth
Comment 4
2008-10-12 14:16:54 PDT
Patch does not apply cleanly. The merge is probably easy, but I'm going to punt on this for now.
Darin Adler
Comment 5
2008-10-12 19:20:55 PDT
http://trac.webkit.org/changeset/37554
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug