Bug 215219 - [ews] Add method to send email notifications to patch author for build failure
Summary: [ews] Add method to send email notifications to patch author for build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 215220
  Show dependency tree / graph
 
Reported: 2020-08-06 09:02 PDT by Aakash Jain
Modified: 2020-08-24 12:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2020-08-06 09:04 PDT, Aakash Jain 		jbedard: review+
Details | Formatted Diff | Diff
sample email (148.36 KB, image/png)
2020-08-06 09:40 PDT, Aakash Jain 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-08-06 09:02:02 PDT 
Add method to send email notifications to patch author for build failures in EWS.
Comment 1 Aakash Jain 2020-08-06 09:04:56 PDT 
Created attachment 406085 [details]
Patch
Comment 2 Aakash Jain 2020-08-06 09:06:13 PDT 
This patch only adds the ability to send emails for build failures introduced by patch, but doesn't enable the email sending yet.
Comment 3 Aakash Jain 2020-08-06 09:40:27 PDT 
Created attachment 406087 [details]
sample email
Comment 4 Aakash Jain 2020-08-06 09:41:22 PDT 
> sample email
Based on failure in https://ews-build.webkit.org/#/builders/8/builds/31968
Comment 5 Jonathan Bedard 2020-08-06 11:21:56 PDT 
Comment on attachment 406085 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406085&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1446
> +    def send_email_for_new_build_failure(self):

We probably need some smarts so we don't email engineers about patches marked obsolete, and maybe even to avoid sending emails if a patch is not marked for review.
Comment 6 Aakash Jain 2020-08-06 11:38:10 PDT 
Committed r265341: <https://trac.webkit.org/changeset/265341>
Comment 7 Radar WebKit Bug Importer 2020-08-06 11:39:41 PDT 
<rdar://problem/66637362>