Bug 215206 - Support AXCoreObject::elementPath for text elements.
Summary: Support AXCoreObject::elementPath for text elements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-05 18:39 PDT by Andres Gonzalez
Modified: 2020-10-15 19:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2020-08-05 18:42 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (9.26 KB, patch)
2020-10-12 20:29 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (10.12 KB, patch)
2020-10-14 08:22 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-08-05 18:39:30 PDT 
Support AXCoreObject::elementPath for text elements.
Comment 1 Andres Gonzalez 2020-08-05 18:42:57 PDT 
Created attachment 406066 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-12 18:40:17 PDT 
<rdar://problem/66950893>
Comment 3 Andres Gonzalez 2020-10-12 20:29:56 PDT 
Created attachment 411192 [details]
Patch
Comment 4 chris fleizach 2020-10-12 23:28:34 PDT 
Comment on attachment 411192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411192&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> +                && unionRect.x() - rects[i].x() > xTolerance) {

will this work for RTL languages too?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914
> +                // rect is in a new line and to the left of previous rects

can you make this comment a full sentence
Comment 5 Andres Gonzalez 2020-10-14 08:22:14 PDT 
Created attachment 411324 [details]
Patch
Comment 6 Andres Gonzalez 2020-10-14 08:24:18 PDT 
(In reply to chris fleizach from comment #4)
> Comment on attachment 411192 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411192&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> > +                && unionRect.x() - rects[i].x() > xTolerance) {
> 
> will this work for RTL languages too?

Fixed, checking for rtl text and adjusting check.
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:914
> > +                // rect is in a new line and to the left of previous rects
> 
> can you make this comment a full sentence

Fixed.
Comment 7 chris fleizach 2020-10-14 15:08:18 PDT 
Comment on attachment 411324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411324&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:913
> +        for (size_t i = 1; i < rects.size(); ++i) {

can you cache rects.size() outside of the loop
Comment 8 EWS 2020-10-14 15:47:32 PDT 
Committed r268494: <https://trac.webkit.org/changeset/268494>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411324 [details].