Bug 215200 - MediaElementAudioSourceNode interface should have a constructor
Summary: MediaElementAudioSourceNode interface should have a constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://webaudio.github.io/web-audio-...
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-05 16:24 PDT by Chris Dumez
Modified: 2020-08-06 09:19 PDT (History)
15 users (show)

See Also:

Attachments
Patch (41.90 KB, patch)
2020-08-05 17:29 PDT, Chris Dumez 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-05 16:24:03 PDT 
MediaElementAudioSourceNode interface should have a constructor:
- https://webaudio.github.io/web-audio-api/#mediaelementaudiosourcenode
Comment 1 Chris Dumez 2020-08-05 17:29:17 PDT 
Created attachment 406059 [details]
Patch
Comment 2 youenn fablet 2020-08-06 01:40:25 PDT 
Comment on attachment 406059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406059&action=review

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55
> +    context.lazyInitialize();

We could move this after the next if check to keep existing behavior and be more lazy.
Comment 3 Chris Dumez 2020-08-06 09:18:09 PDT 
Committed r265330: <https://trac.webkit.org/changeset/265330>
Comment 4 Chris Dumez 2020-08-06 09:18:26 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 406059 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=406059&action=review
> 
> > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:55
> > +    context.lazyInitialize();
> 
> We could move this after the next if check to keep existing behavior and be
> more lazy.

Fixed before landing.
Comment 5 Radar WebKit Bug Importer 2020-08-06 09:19:43 PDT 
<rdar://problem/66630110>