Bug 215187 - Add a createWebArchiveData from a custom scheme API test
Summary: Add a createWebArchiveData from a custom scheme API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-05 13:36 PDT by Brady Eidson
Modified: 2020-08-08 11:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.93 KB, patch)
2020-08-05 13:40 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.54 KB, patch)
2020-08-05 14:39 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.54 KB, patch)
2020-08-05 14:47 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.63 KB, patch)
2020-08-05 14:53 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2020-08-05 15:02 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch (8.72 KB, patch)
2020-08-05 15:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2020-08-05 13:36:43 PDT 
Add a createWebArchiveData from a custom scheme API test
Comment 1 Brady Eidson 2020-08-05 13:40:44 PDT 
Created attachment 406034 [details]
Patch
Comment 2 Tim Horton 2020-08-05 13:42:44 PDT 
Comment on attachment 406034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406034&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:72
> +    static bool done = false;

__block instead of static?
Comment 3 Brady Eidson 2020-08-05 14:39:41 PDT 
Created attachment 406040 [details]
Patch
Comment 4 Brady Eidson 2020-08-05 14:47:45 PDT 
Created attachment 406042 [details]
Patch
Comment 5 Brady Eidson 2020-08-05 14:53:12 PDT 
Created attachment 406045 [details]
Patch
Comment 6 Brady Eidson 2020-08-05 15:02:34 PDT 
Created attachment 406046 [details]
Patch
Comment 7 Brady Eidson 2020-08-05 15:23:18 PDT 
Created attachment 406049 [details]
Patch
Comment 8 EWS 2020-08-05 16:20:03 PDT 
Committed r265310: <https://trac.webkit.org/changeset/265310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406049 [details].
Comment 9 Radar WebKit Bug Importer 2020-08-05 16:21:18 PDT 
<rdar://problem/66599058>
Comment 10 Darin Adler 2020-08-08 11:47:25 PDT 
Comment on attachment 406046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406046&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm:93
> +    [webView loadData:archiveData.get() MIMEType:(NSString *)kUTTypeArchive characterEncodingName:@"utf-8" baseURL:[NSURL URLWithString:@"about:blank"]];

iOS build says:

CreateWebArchive.mm:93:62: error: use of undeclared identifier 'kUTTypeArchive'