Bug 215179 - r264813 breaks Make runner on remote devices
Summary: r264813 breaks Make runner on remote devices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Lima
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-05 11:49 PDT by Caio Lima
Modified: 2020-08-05 16:55 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2020-08-05 12:05 PDT, Caio Lima
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Lima 2020-08-05 11:49:11 PDT
The problem is that changes introduced by r264813 sets `LD_LIBRARY_PATH` wrongly. This can cause a variety of issues depending on configuration fo the remote runner.
Comment 1 Caio Lima 2020-08-05 12:05:41 PDT
Created attachment 406021 [details]
Patch
Comment 2 Caio Lima 2020-08-05 16:48:47 PDT
Comment on attachment 406021 [details]
Patch

Win failure is very likely unrelated, since this change is Linux specific. Thank you for the review!
Comment 3 EWS 2020-08-05 16:54:50 PDT
Committed r265312: <https://trac.webkit.org/changeset/265312>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406021 [details].
Comment 4 Radar WebKit Bug Importer 2020-08-05 16:55:17 PDT
<rdar://problem/66600583>