Bug 215169 - Add constructor to ConvolverNode
Summary: Add constructor to ConvolverNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://webaudio.github.io/web-audio-...
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-05 09:15 PDT by Chris Dumez
Modified: 2020-08-05 12:24 PDT (History)
15 users (show)

See Also:

Attachments
Patch (41.31 KB, patch)
2020-08-05 10:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (41.93 KB, patch)
2020-08-05 11:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (41.96 KB, patch)
2020-08-05 11:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-05 09:15:28 PDT 
Add constructor to ConvolverNode:
- https://webaudio.github.io/web-audio-api/#ConvolverNode
Comment 1 Chris Dumez 2020-08-05 10:50:11 PDT 
Created attachment 406013 [details]
Patch
Comment 2 Eric Carlson 2020-08-05 11:04:43 PDT 
Comment on attachment 406013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406013&action=review

> Source/WebCore/Modules/webaudio/ConvolverNode.cpp:210
> +        return Exception { NotSupportedError, "ConvolverNode's channel count cannot greater than 2"_s };

s/channel count cannot greater than 2/channel count cannot be greater than 2/

> Source/WebCore/Modules/webaudio/ConvolverNode.idl:3
> + * Copyright (C) 2020, Apple Inc. All rights reserved.

Is there any reason to update this copyright but not the .cpp or .h files?
Comment 3 Chris Dumez 2020-08-05 11:32:28 PDT 
Created attachment 406017 [details]
Patch
Comment 4 Chris Dumez 2020-08-05 11:40:21 PDT 
Created attachment 406018 [details]
Patch
Comment 5 EWS 2020-08-05 12:23:10 PDT 
Committed r265298: <https://trac.webkit.org/changeset/265298>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406018 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-05 12:24:17 PDT 
<rdar://problem/66587740>