WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
215166
Add a quota delegate test for miniaturized/deminiaturized pages
https://bugs.webkit.org/show_bug.cgi?id=215166
Summary
Add a quota delegate test for miniaturized/deminiaturized pages
youenn fablet
Reported
2020-08-05 07:17:11 PDT
Add a quota delegate test for miniaturized/deminiaturized pages
Attachments
Patch
(5.27 KB, patch)
2020-08-05 07:21 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(5.29 KB, patch)
2020-08-05 09:23 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(5.51 KB, patch)
2020-08-07 14:23 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2020-08-05 07:21:09 PDT
Created
attachment 405996
[details]
Patch
youenn fablet
Comment 2
2020-08-05 09:23:54 PDT
Created
attachment 406006
[details]
Patch
youenn fablet
Comment 3
2020-08-05 10:00:07 PDT
I added some logging in case this test also fails in Debug Mac bots.
youenn fablet
Comment 4
2020-08-07 07:51:59 PDT
Ping review
Alex Christensen
Comment 5
2020-08-07 09:11:34 PDT
Comment on
attachment 406006
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=406006&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:138 > +-(String)receivedMessage {
space before (, { should be on next line.
> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278 > + NSLog(@"QuotaDelegateHidden 1");
Why are these here? Do you think it will time out and you want to see where it does?
youenn fablet
Comment 6
2020-08-07 09:14:58 PDT
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:278 > > + NSLog(@"QuotaDelegateHidden 1"); > > Why are these here? Do you think it will time out and you want to see where > it does?
Yes, the current StorageQuota delegate tests time out on two debug bots (cannot repro locally though).
youenn fablet
Comment 7
2020-08-07 14:23:08 PDT
Created
attachment 406213
[details]
Patch for landing
EWS
Comment 8
2020-08-08 03:37:09 PDT
Committed
r265406
: <
https://trac.webkit.org/changeset/265406
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 406213
[details]
.
Radar WebKit Bug Importer
Comment 9
2020-08-08 03:38:27 PDT
<
rdar://problem/66721715
>
Simon Fraser (smfr)
Comment 10
2020-08-08 08:48:16 PDT
Comment on
attachment 406213
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=406213&action=review
> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281 > + NSLog(@"QuotaDelegateHidden 1");
Did you mean to leave in the NSLogging?
youenn fablet
Comment 11
2020-08-08 10:45:05 PDT
Comment on
attachment 406213
[details]
Patch for landing View in context:
https://bugs.webkit.org/attachment.cgi?id=406213&action=review
>> Tools/TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:281 >> + NSLog(@"QuotaDelegateHidden 1"); > > Did you mean to leave in the NSLogging?
Yes, I am investigating some timeout issues on specific bots in StorageQuota.mm I plan to remove them once no longer needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug