Bug 215160 - Introduce a Vector::isolatedCopy() &&
Summary: Introduce a Vector::isolatedCopy() &&
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-05 02:28 PDT by youenn fablet
Modified: 2020-08-07 15:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2020-08-05 03:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-05 02:28:13 PDT 
Introduce a Vector::isolatedCopy() &&.
This is for instance used in RegistrationDatabase.
Comment 1 youenn fablet 2020-08-05 03:21:56 PDT 
Created attachment 405993 [details]
Patch
Comment 2 Alex Christensen 2020-08-06 08:41:19 PDT 
Comment on attachment 405993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review

> Source/WTF/ChangeLog:9
> +        This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges.

Can we change this at the same time?
Comment 3 youenn fablet 2020-08-07 04:10:27 PDT 
Comment on attachment 405993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405993&action=review

>> Source/WTF/ChangeLog:9
>> +        This can make a Vector<String>::isolatedCopy() allocate no memory at all in cases like RegistrationDatabase::schedulePushChanges.
> 
> Can we change this at the same time?

RegistrationDatabase::schedulePushChanges already does WTFMove(vector).isolatedCopy()
Comment 4 EWS 2020-08-07 04:33:02 PDT 
Committed r265369: <https://trac.webkit.org/changeset/265369>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405993 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-07 04:34:34 PDT 
<rdar://problem/66674326>
Comment 6 Darin Adler 2020-08-07 15:55:37 PDT 
Looks good!