Bug 215154 - [Cocoa] Remove obsolete sandbox extension after r264178
Summary: [Cocoa] Remove obsolete sandbox extension after r264178
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-04 18:36 PDT by Per Arne Vollan
Modified: 2020-08-05 11:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.71 KB, patch)
2020-08-04 18:38 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2020-08-05 11:15 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-08-04 18:36:18 PDT
After r264178, the code related to issuing an extension to com.apple.lsd.mapdb is obsolete, and should be removed.
Comment 1 Per Arne Vollan 2020-08-04 18:36:35 PDT
rdar://problem/66549976
Comment 2 Per Arne Vollan 2020-08-04 18:38:39 PDT
Created attachment 405976 [details]
Patch
Comment 3 Brent Fulgham 2020-08-05 10:59:48 PDT
Comment on attachment 405976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405976&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:-427
> -        parameters.mapDBExtensionHandle = WTFMove(mapDBHandle);

Can we get rid of parameters.mapDBExtensionHandle, too? Or is it still used in some cases?
Comment 4 Per Arne Vollan 2020-08-05 11:06:39 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 405976 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405976&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:-427
> > -        parameters.mapDBExtensionHandle = WTFMove(mapDBHandle);
> 
> Can we get rid of parameters.mapDBExtensionHandle, too? Or is it still used
> in some cases?

That is a good point! Will fix.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2020-08-05 11:15:06 PDT
Created attachment 406014 [details]
Patch
Comment 6 EWS 2020-08-05 11:50:37 PDT
Committed r265295: <https://trac.webkit.org/changeset/265295>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406014 [details].