Bug 215154 – [Cocoa] Remove obsolete sandbox extension after r264178

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

After r264178, the code related to issuing an extension to com.apple.lsd.mapdb is obsolete, and should be removed.

[Per Arne Vollan]

rdar://problem/66549976

[Per Arne Vollan]

Created attachment 405976 [details]
Patch

[Brent Fulgham]

Comment on attachment 405976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405976&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:-427
> -        parameters.mapDBExtensionHandle = WTFMove(mapDBHandle);

Can we get rid of parameters.mapDBExtensionHandle, too? Or is it still used in some cases?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 405976 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405976&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:-427
> > -        parameters.mapDBExtensionHandle = WTFMove(mapDBHandle);
> 
> Can we get rid of parameters.mapDBExtensionHandle, too? Or is it still used
> in some cases?

That is a good point! Will fix.

Thanks for reviewing!

[Per Arne Vollan]

Created attachment 406014 [details]
Patch

[EWS]

Committed r265295: <https://trac.webkit.org/changeset/265295>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406014 [details].