Bug 215149 - AX: WebCore should provide a way to get raw role for accessibility objects
Summary: AX: WebCore should provide a way to get raw role for accessibility objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac macOS 10.15
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-04 16:51 PDT by Eric Liang
Modified: 2020-08-05 00:22 PDT (History)
9 users (show)

See Also:


Attachments
Patch (27.47 KB, patch)
2020-08-04 17:17 PDT, Eric Liang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Liang 2020-08-04 16:51:03 PDT
AX: WebCore should provide a way to get raw role for accessibility objects

This allows us to get it in the WebKit bundle
Comment 1 Radar WebKit Bug Importer 2020-08-04 16:51:16 PDT
<rdar://problem/66548775>
Comment 2 Eric Liang 2020-08-04 17:17:35 PDT
Created attachment 405963 [details]
Patch
Comment 3 chris fleizach 2020-08-04 18:23:13 PDT
Comment on attachment 405963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405963&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503
> +    return accessibilityRoleToString(self.axBackingObject->roleValue());

what are you going to do with this one since it's not localized?
Comment 4 Eric Liang 2020-08-04 18:28:44 PDT
(In reply to chris fleizach from comment #3)
> Comment on attachment 405963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405963&action=review
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:503
> > +    return accessibilityRoleToString(self.axBackingObject->roleValue());
> 
> what are you going to do with this one since it's not localized?

This is so in the WebKit iOS bundle I can check the raw roles to add container information. Yea it should not be localized.
Comment 5 EWS 2020-08-05 00:22:11 PDT
Committed r265278: <https://trac.webkit.org/changeset/265278>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405963 [details].