Bug 215148 - Align BiquadFilterNode.getFrequencyResponse() with the specification
Summary: Align BiquadFilterNode.getFrequencyResponse() with the specification
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://webaudio.github.io/web-audio-...
Keywords: InRadar
Depends on: 215144
Blocks: 212611
  Show dependency treegraph
Reported: 2020-08-04 16:24 PDT by Chris Dumez
Modified: 2020-08-05 09:55 PDT (History)
12 users (show)

See Also:

Patch (7.85 KB, patch)
2020-08-04 16:26 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2020-08-05 09:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-04 16:24:05 PDT
Align BiquadFilterNode.getFrequencyResponse() with the specification:
- https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-getfrequencyresponse
Comment 1 Chris Dumez 2020-08-04 16:26:56 PDT
Created attachment 405961 [details]
Comment 2 Eric Carlson 2020-08-05 09:03:26 PDT
Comment on attachment 405961 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=405961&action=review

> Source/WebCore/Modules/webaudio/BiquadFilterNode.cpp:89
> +        return Exception { InvalidStateError, "The arrays passed in argument must have the same length" };

s/arrays passed in argument/arrays passed as arguments/
Comment 3 Chris Dumez 2020-08-05 09:10:41 PDT
Created attachment 406004 [details]
Comment 4 EWS 2020-08-05 09:54:52 PDT
Committed r265291: <https://trac.webkit.org/changeset/265291>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406004 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-05 09:55:43 PDT