Bug 215138 – Web Inspector: Use border-inline-start/end properties instead of border-left/right for DataGrid and Table

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Simplify LTR/RTL CSS code by using logical CSS properties.

This is a follow up for Bug 214563 - Web Inspector: Change DataGrid and Table styles to closer match macOS.

[Nikita Vasilyev]

Created attachment 405943 [details]
Patch

[Devin Rousso]

Comment on attachment 405943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405943&action=review

r=me, awesome!

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:-96
> -body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content {

please double check that removing `body[dir=*]` doesn't cause this to be overridden by some other CSS declaration due to a lower specificity

> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:97
> +    border-inline-end: var(--data-grid-column-border-end);

we should inline the `1px solid var(--border-color)` and eliminate `--data-grid-column-border-end` while we're at it too 😃

[Nikita Vasilyev]

Comment on attachment 405943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405943&action=review

>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:-96
>> -body[dir=ltr] .data-grid th:not(:last-child) > .header-cell-content {
> 
> please double check that removing `body[dir=*]` doesn't cause this to be overridden by some other CSS declaration due to a lower specificity

Valid concern but there are no other rules that set border on this element.

>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:97
>> +    border-inline-end: var(--data-grid-column-border-end);
> 
> we should inline the `1px solid var(--border-color)` and eliminate `--data-grid-column-border-end` while we're at it too 😃

Makes sense.

[Nikita Vasilyev]

Created attachment 405946 [details]
Patch

[EWS]

Committed r265262: <https://trac.webkit.org/changeset/265262>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405946 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66544335>