Bug 215120 - RegistrationDatabase::openSQLiteDatabase can spin
Summary: RegistrationDatabase::openSQLiteDatabase can spin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-04 02:05 PDT by youenn fablet
Modified: 2020-08-05 04:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (12.16 KB, patch)
2020-08-04 02:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (12.20 KB, patch)
2020-08-04 04:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (11.49 KB, patch)
2020-08-05 01:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-04 02:05:55 PDT 
RegistrationDatabase::openSQLiteDatabase can spin
Comment 1 youenn fablet 2020-08-04 02:08:19 PDT 
<rdar://problem/64850347>
Comment 2 youenn fablet 2020-08-04 02:08:58 PDT 
Probably a regression from https://bugs.webkit.org/show_bug.cgi?id=201002
Comment 3 youenn fablet 2020-08-04 02:40:31 PDT 
Created attachment 405910 [details]
Patch
Comment 4 youenn fablet 2020-08-04 04:51:41 PDT 
Created attachment 405914 [details]
Patch
Comment 5 youenn fablet 2020-08-04 08:52:37 PDT 
win failure unrelated
Comment 6 youenn fablet 2020-08-04 08:55:23 PDT 
Comment on attachment 405914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405914&action=review

> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:332
> +    postTaskToWorkQueue([this, pushCounter = ++m_pushCounter, completionHandler = WTFMove(completionHandler)]() mutable {

I guess I could push the counter increment to postTaskToWorkQueue
Comment 7 Geoffrey Garen 2020-08-04 08:59:30 PDT 
Comment on attachment 405914 [details]
Patch

r=me
Comment 8 Alex Christensen 2020-08-04 23:00:03 PDT 
Comment on attachment 405914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405914&action=review

>> Source/WebCore/workers/service/server/RegistrationDatabase.cpp:332
>> +    postTaskToWorkQueue([this, pushCounter = ++m_pushCounter, completionHandler = WTFMove(completionHandler)]() mutable {
> 
> I guess I could push the counter increment to postTaskToWorkQueue

Yeah, as it stands now this is an unused capture.
Comment 9 youenn fablet 2020-08-05 01:46:20 PDT 
Created attachment 405991 [details]
Patch for landing
Comment 10 EWS 2020-08-05 04:03:13 PDT 
Committed r265283: <https://trac.webkit.org/changeset/265283>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405991 [details].