Bug 21512 - Change DOMWindow timer clamp to 4ms for V8
Summary: Change DOMWindow timer clamp to 4ms for V8
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Mike Belshe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-09 19:18 PDT by Mike Belshe
Modified: 2008-10-09 20:10 PDT (History)
1 user (show)

See Also:

Attachments
DOMWindow.cpp patch (3.41 KB, patch)
2008-10-09 19:22 PDT, Mike Belshe 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Belshe 2008-10-09 19:18:38 PDT 
To avoid potential CPU starvation issues; increase the timer clamp from 1ms to 4ms, and bring back the dynamic throttle which introduces the clamp only after successive small timers.
Comment 1 Mike Belshe 2008-10-09 19:22:22 PDT 
Created attachment 24250 [details]
DOMWindow.cpp patch

* Raise the clamp from 1ms to 4ms.
* Re-add the dynamic clamp (timerNestingLevel).  We should figure out how to merge this code with JSDOMWindowBase.
* Fix whitespace style issues.
* Changes are confined to ifdef V8 areas.
Comment 2 Eric Seidel (no email) 2008-10-09 19:33:15 PDT 
Comment on attachment 24250 [details]
DOMWindow.cpp patch

I'm wondering if this is against WebKit's DOM window since timerFired has the { on the "wrong" place.  Sam should really be the one to look at this.
Comment 3 Mike Belshe 2008-10-09 19:40:34 PDT 
Invalidating this bug.

Eric points out that I was confused about how the branching is being done.

Will submit later when this is relevant.