Bug 215096 - Add constructor for AudioBufferSourceNode
Summary: Add constructor for AudioBufferSourceNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#Audio...
Keywords: InRadar
Depends on:
Blocks: 212611 215106
  Show dependency tree / graph
 
Reported: 2020-08-03 13:03 PDT by Chris Dumez
Modified: 2020-08-03 17:33 PDT (History)
16 users (show)

See Also:

Attachments
Patch (72.53 KB, patch)
2020-08-03 14:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.69 KB, patch)
2020-08-03 15:36 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.71 KB, patch)
2020-08-03 16:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-03 13:03:16 PDT 
Add constructor for AudioBufferSourceNode, as per:
- https://www.w3.org/TR/webaudio/#AudioBufferSourceNode
Comment 1 Chris Dumez 2020-08-03 14:15:12 PDT 
Created attachment 405864 [details]
Patch
Comment 2 Darin Adler 2020-08-03 14:46:40 PDT 
Comment on attachment 405864 [details]
Patch

Seems that default values for some fields are listed in multiple places. I bet some of the places aren’t actually affecting things. Would be nice to reduce this a bit in the future. Default values that have no effect.
Comment 3 Chris Dumez 2020-08-03 15:36:16 PDT 
Created attachment 405874 [details]
Patch
Comment 4 Chris Dumez 2020-08-03 16:06:51 PDT 
Created attachment 405882 [details]
Patch
Comment 5 EWS 2020-08-03 17:32:01 PDT 
Committed r265233: <https://trac.webkit.org/changeset/265233>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405882 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-03 17:33:19 PDT 
<rdar://problem/66500063>