RESOLVED FIXED 215091
Remove the ENABLE_DATA_INTERACTION feature flag 
https://bugs.webkit.org/show_bug.cgi?id=215091
Summary Remove the ENABLE_DATA_INTERACTION feature flag
Wenson Hsieh
Reported 2020-08-03 11:19:49 PDT
This feature flag was used to guard iOS drag and drop code prior to WWDC 2017.
Attachments
For EWS (28.35 KB, patch)
2020-08-03 12:20 PDT, Wenson Hsieh 		megan_gardner: review+
DetailsFormatted DiffDiff
Patch (30.29 KB, patch)
2020-08-03 13:58 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-08-03 12:20:33 PDT
Created attachment 405855 [details] For EWS
Megan Gardner
Comment 2 2020-08-03 13:34:35 PDT
Comment on attachment 405855 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=405855&action=review > Source/WebCore/page/FocusController.cpp:808 > +#if PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT) I'm assuming there's good reason that some of these are IOS_FAMILY and DRAG_SUPPORT and some are just one or the other. > Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:29 > +#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) nit: would you mind flipping this one so the order matches the others? > Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:874 > +#endif // ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) nit: ditto
Wenson Hsieh
Comment 3 2020-08-03 13:42:45 PDT
Comment on attachment 405855 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=405855&action=review >> Source/WebCore/page/FocusController.cpp:808 >> +#if PLATFORM(IOS_FAMILY) && ENABLE(DRAG_SUPPORT) > > I'm assuming there's good reason that some of these are IOS_FAMILY and DRAG_SUPPORT and some are just one or the other. Yes — some of these places (e.g. WKContentViewInteraction) are already guarded by PLATFORM(IOS_FAMILY), so only ENABLE(DRAG_SUPPORT) is needed, and vice versa. >> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:29 >> +#if ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) > > nit: would you mind flipping this one so the order matches the others? Good catch! Will do. >> Source/WebCore/platform/ios/WebItemProviderPasteboard.mm:874 >> +#endif // ENABLE(DRAG_SUPPORT) && PLATFORM(IOS_FAMILY) > > nit: ditto 👍🏻
Wenson Hsieh
Comment 4 2020-08-03 13:58:22 PDT
Created attachment 405863 [details] Patch
EWS
Comment 5 2020-08-03 15:48:53 PDT
Committed r265228: <https://trac.webkit.org/changeset/265228> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405863 [details].
Note You need to log in before you can comment on or make changes to this bug.