Bug 215086 - results.webkit.org: Return worker status to caller
Summary: results.webkit.org: Return worker status to caller
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-03 09:36 PDT by Jonathan Bedard
Modified: 2020-08-05 14:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.69 KB, patch)
2020-08-03 09:43 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2020-08-04 15:07 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (5.71 KB, patch)
2020-08-05 13:32 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-08-03 09:36:56 PDT
At the moment, the worker process has no way to know if it's actually successful in processing archives. We should return that information, instead of relying solely on exceptions.
Comment 1 Jonathan Bedard 2020-08-03 09:40:34 PDT
<rdar://problem/66476525>
Comment 2 Jonathan Bedard 2020-08-03 09:43:35 PDT
Created attachment 405842 [details]
Patch
Comment 3 Jonathan Bedard 2020-08-04 15:07:58 PDT
Created attachment 405950 [details]
Patch
Comment 4 Aakash Jain 2020-08-05 07:03:14 PDT
Comment on attachment 405950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405950&action=review

> Tools/resultsdbpy/resultsdbpy/model/upload_context.py:200
>      def do_processing_work(self):

when is this function expected to return false?
Comment 5 Jonathan Bedard 2020-08-05 07:15:25 PDT
Comment on attachment 405950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405950&action=review

>> Tools/resultsdbpy/resultsdbpy/model/upload_context.py:200
>>      def do_processing_work(self):
> 
> when is this function expected to return false?

This function should return false if no jobs are completed successfully, indicating that a given worker, for some reason, is stuck.
Comment 6 Aakash Jain 2020-08-05 13:01:22 PDT
Comment on attachment 405950 [details]
Patch

rs=me
Comment 7 Jonathan Bedard 2020-08-05 13:32:17 PDT
Created attachment 406032 [details]
Patch for landing
Comment 8 EWS 2020-08-05 14:12:32 PDT
Committed r265305: <https://trac.webkit.org/changeset/265305>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406032 [details].