Bug 215083 – Add constructor to DelayNode

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Chris Dumez]

Add constructor to DelayNode:
- https://www.w3.org/TR/webaudio/#DelayNode

[Chris Dumez]

Created attachment 405851 [details]
Patch

[Clark Wang]

Comment on attachment 405851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review

> Source/WebCore/Modules/webaudio/DelayNode.h:36
> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);

I think DelayOptions parameter is optional, so should provide a default value.

[Chris Dumez]

Comment on attachment 405851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review

>> Source/WebCore/Modules/webaudio/DelayNode.h:36
>> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);
> 
> I think DelayOptions parameter is optional, so should provide a default value.

It is not necessary. Bindings are smart enough to always pass us a default-initialized dictionary.

[Clark Wang]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 405851 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405851&action=review
> 
> >> Source/WebCore/Modules/webaudio/DelayNode.h:36
> >> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);
> > 
> > I think DelayOptions parameter is optional, so should provide a default value.
> 
> It is not necessary. Bindings are smart enough to always pass us a
> default-initialized dictionary.

Ah interesting, I'll take this into account for my future patches as well.

[EWS]

Committed r265221: <https://trac.webkit.org/changeset/265221>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405851 [details].

[Radar WebKit Bug Importer]

<rdar://problem/66497071>