Bug 215072 - Improve the check-for-duplicated-platform-test-results script
Summary: Improve the check-for-duplicated-platform-test-results script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-01 21:37 PDT by Simon Fraser (smfr)
Modified: 2020-08-03 13:33 PDT (History)
8 users (show)

See Also:


Attachments
Patch (14.42 KB, patch)
2020-08-01 21:43 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-08-01 21:37:48 PDT
Improve the check-for-duplicated-platform-test-results script
Comment 1 Simon Fraser (smfr) 2020-08-01 21:43:39 PDT
Created attachment 405806 [details]
Patch
Comment 2 Darin Adler 2020-08-02 12:25:32 PDT
I haven’t studied the relationship between the two, but I would love it if the rules for search path in run-webkit-tests was the same as in this script. So if it changed, the two would continue to share the same behavior. Seems possible given all the library things we do with Python.
Comment 3 Simon Fraser (smfr) 2020-08-02 23:22:41 PDT
(In reply to Darin Adler from comment #2)
> I haven’t studied the relationship between the two, but I would love it if
> the rules for search path in run-webkit-tests was the same as in this
> script. So if it changed, the two would continue to share the same behavior.
> Seems possible given all the library things we do with Python.

I think this script gets its search path rules from webkitpy, so they should be the same.

What's odd about this script is that it creates Ports for platforms which are not the current platform, which never happens with run-webkit-tests. That probably results in some differences.
Comment 4 EWS 2020-08-02 23:41:50 PDT
Committed r265191: <https://trac.webkit.org/changeset/265191>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405806 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-03 13:33:01 PDT
<rdar://problem/66489056>